[Latte] Add tryRequestQuota for SuspendingRatelimit
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to wait for the quota
wasdennnoch
reviewed
Aug 4, 2024
wasdennnoch
approved these changes
Aug 9, 2024
Comment on lines
+56
to
+57
| check(remainingQuota > 0) | ||
| remainingQuota-- |
There was a problem hiding this comment.
Given thas these two lines are the same in the new and the old method, I think we should also move them to the common function and perhaps rename it to something a bit more generic then, like calculateQuota. Otherwise LGTM.
There was a problem hiding this comment.
Somehow, moving these two lines to a common function would result in the function misbehaving (failing), so yeah, I think we can just keep it like that, given that it's just two lines. What do you think? (I think it's because of the check that's failing).
wasdennnoch
changed the title
tryRequestQuota for SuspendingRatelimittryRequestQuota for SuspendingRatelimit
wasdennnoch
deleted the
miu/feat/suspending-ratelimit-try-request-quota
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds
tryRequestQuotaforSuspendingRatelimitto enable a wider range of applications, such as rate-limiting specific commands. UnlikerequestQuota,tryRequestQuotadoesn't wait for the quota to be available, but instead, returns a pair of a Boolean (canProceed) and a nullable Long (remainingWaitTime) which can be useful for such applications.